Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adds ratio of fulfilled certificate requests in status message #137

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

saltiyazan
Copy link
Contributor

@saltiyazan saltiyazan commented Jun 10, 2024

Description

Fixes canonical/httprequest-lego-k8s-operator#154
The status message will reflect the number of certificate requests that are fulfilled, making the user conscious that there might be some issues if this stays there for long.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I Have bumped the version of the library

@saltiyazan saltiyazan requested a review from a team as a code owner June 10, 2024 15:40
@saltiyazan saltiyazan requested a review from gruyaume June 11, 2024 06:36
@saltiyazan saltiyazan changed the title chore: Adds number of pending certificate requests in status message chore: Adds ration of fulfilled certificate requests in status message Jun 11, 2024
@saltiyazan saltiyazan changed the title chore: Adds ration of fulfilled certificate requests in status message chore: Adds ratio of fulfilled certificate requests in status message Jun 11, 2024
@saltiyazan saltiyazan merged commit 7fde230 into main Jun 11, 2024
19 checks passed
@saltiyazan saltiyazan deleted the TLSENG-261-add-cert-fulfilment-info branch June 11, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants