Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charms.observability_libs.v0.juju_topology lib is deprecated #310

Closed
simondeziel opened this issue Sep 28, 2023 · 1 comment · Fixed by #331
Closed

charms.observability_libs.v0.juju_topology lib is deprecated #310

simondeziel opened this issue Sep 28, 2023 · 1 comment · Fixed by #331
Labels
Status: Triage Type: Enhancement

Comments

@simondeziel
Copy link
Member

Enhancement Proposal

https://github.com/canonical/observability-libs/blob/main/lib/charms/observability_libs/v0/juju_topology.py#L89-L94:

class JujuTopology:
    """JujuTopology is used for storing, generating and formatting juju topology information.

    DEPRECATED: This class is deprecated. Use `pip install cosl` and
    `from cosl.juju_topology import JujuTopology` instead.
    """

Other bits of the observability stack moved to cosl already so it'd be great for Loki to do the same.
simondeziel added a commit to simondeziel/charm-lxd that referenced this issue Sep 28, 2023
@simondeziel
JujuTopology is now provided by cosl
8830b6b 
We cannot remove `charms.observability_libs.v0.juju_topology` just yet
as the Loki lib still depend on it. The request for Loki to move to `cosl`:
canonical/loki-k8s-operator#310

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel simondeziel mentioned this issue Sep 28, 2023
Merged
@sed-i
Copy link
Contributor

sed-i commented Sep 28, 2023

I was just thinking the same. Thanks for filing the issue!

@lucabello lucabello mentioned this issue Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Triage Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use cosl for JujuTopology canonical/loki-k8s-operator
2 participants
@simondeziel @sed-i