Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promtail is currently hard-coded to amd64. Needs to support arm64 as well #83

Closed
simskij opened this issue Jan 27, 2022 · 3 comments
Closed
Assignees

Comments

@simskij
Copy link
Member

simskij commented Jan 27, 2022

See

PROMTAIL_BINARY_ZIP_URL = (
"https://github.com/grafana/loki/releases/download/v2.4.1/promtail-linux-amd64.zip"
)
# Paths in `charm` container
BINARY_DIR = "/tmp"
BINARY_ZIP_FILE_NAME = "promtail-linux-amd64.zip"
BINARY_ZIP_PATH = "{}/{}".format(BINARY_DIR, BINARY_ZIP_FILE_NAME)
BINARY_FILE_NAME = "promtail-linux-amd64"
BINARY_PATH = "{}/{}".format(BINARY_DIR, BINARY_FILE_NAME)
BINARY_ZIP_SHA256SUM = "978391a174e71cfef444ab9dc012f95d5d7eae0d682eaf1da2ea18f793452031"
BINARY_SHA256SUM = "00ed6a4b899698abc97d471c483a6a7e7c95e761714f872eb8d6ffd45f3d32e6"

@balbirthomas
Copy link
Contributor

After discussion with @simskij an additional requirement is that the LogProxyConsumer should be able to detect if the Consumer charm is providing a Promtail resource and in this case the Promtail binary should not be downloaded from the release page. This allows for air gapped deployments.

@rbarry82
Copy link
Contributor

rbarry82 commented May 4, 2022

@balbirthomas closed in #158 ?

@balbirthomas
Copy link
Contributor

Closing this since we have extensibility to add new architectures but are lacking binaries to do so. I created #163 to track upload of new binaries and update Loki library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants