-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support both AMD64 and ARM64 Promtail binary URLs #158
Conversation
Libraries are not up to date with their remote counterparts. If this was stdout
stderr
|
1 similar comment
Libraries are not up to date with their remote counterparts. If this was stdout
stderr
|
Libraries are not up to date with their remote counterparts. If this was stdout
stderr
|
1 similar comment
Libraries are not up to date with their remote counterparts. If this was stdout
stderr
|
Libraries are not up to date with their remote counterparts. If this was stdout
stderr
|
This commit refactors the LogProxyConsumer object so that it can be used on different hardware architectures such as AMD64 and ARM64. The following changes were made as part of this refactor. - The relation data structure with promtail information set by LokiPushApiProvider has been extended so that it includes + information for multiple architectures + filename of Promtail for each architecture + sha256 sum of Promtail zip for each architecture + sha256 sum of Promtail binary for each architecture - All hardcoding of filename and paths for Promtail binaries were removed. The filenames are extracted from relation data provided by the LokiPushApiProvider, in a architecture dependent way. The LogProxyConsumer selects the correct Promtail filename based on its architecture from the choices offered to by the LokiPushApiProvider. - The _setup_promtail() method has been made idempotent and the check if _is_promtail_installed() has been moved into this method. Hence _setup_promtail() only installs promtail if it has not already been installed. This commit also refactors the Promtail unit tests to be compatible with new method signatures as a result of refactoring LogProxyConsumer to support multiple Promtail architectures.
Libraries are not up to date with their remote counterparts. If this was stdout
stderr
|
Issue
LogProxyConsumer
currently only supports AMD64 architectures. Hence it can not install and use Promtail on other architectures such as ARM64. The purpose of this PR is to support both AMD64 and ARM64 architectures and ensure additional architectures can be easily added in the future.Solution
The following changes were made as part of this refactor.
Context
Explained in "Issue" above.
Testing Instructions
Just deploy Loki and Log proxy consumer and check that logs from promtail are forwarded.
Release Notes
LokiPushApiProvider
andLogProxyConsumer
objects now support AMD64 and ARM64 architectures for Promtail.