Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics based alert rules #181

Merged
merged 3 commits into from Jul 5, 2022
Merged

Metrics based alert rules #181

merged 3 commits into from Jul 5, 2022

Conversation

Abuelodelanada
Copy link
Contributor

@Abuelodelanada Abuelodelanada commented Jul 4, 2022

Issue

This PR adds Loki metric based alert rules for its relation with Prometheus.

Testing Instructions

  • Deploy Loki
  • Deploy Prometheus
  • Relate both charms
  • Check Loki Alert rules are present in Prometheus

Integration test should be added in COS-Lite

@github-actions
Copy link

github-actions bot commented Jul 4, 2022

Libraries are not up to date with their remote counterparts. If this was
not intentional, run charmcraft fetch-libs and commit the updated libs
to your PR branch.

stdout
Library charms.alertmanager_k8s.v0.alertmanager_dispatch was already up to date in version 0.4.                                                                
Library charms.grafana_k8s.v0.grafana_source was already up to date in version 0.10.                                                                           
Library charms.loki_k8s.v0.loki_push_api has local changes, cannot be updated. 
Library charms.observability_libs.v0.juju_topology was already up to date in version 0.2.                                                                      
Library charms.observability_libs.v0.kubernetes_service_patch was already up to date in version 0.6.                                                           
Library charms.prometheus_k8s.v0.prometheus_scrape was already up to date in version 0.20.                                                                     
Library charms.traefik_k8s.v0.ingress_per_unit was already up to date in version 0.10.                                                                         

stderr

@Abuelodelanada Abuelodelanada changed the title WIP: metrics based alert rules Metrics based alert rules Jul 5, 2022
@Abuelodelanada Abuelodelanada marked this pull request as ready for review July 5, 2022 14:18
@github-actions
Copy link

github-actions bot commented Jul 5, 2022

Libraries are not up to date with their remote counterparts. If this was
not intentional, run charmcraft fetch-libs and commit the updated libs
to your PR branch.

stdout
Library charms.alertmanager_k8s.v0.alertmanager_dispatch was already up to date in version 0.4.                                                                
Library charms.grafana_k8s.v0.grafana_source was already up to date in version 0.10.                                                                           
Library charms.loki_k8s.v0.loki_push_api has local changes, cannot be updated. 
Library charms.observability_libs.v0.juju_topology was already up to date in version 0.2.                                                                      
Library charms.observability_libs.v0.kubernetes_service_patch was already up to date in version 0.6.                                                           
Library charms.prometheus_k8s.v0.prometheus_scrape was already up to date in version 0.20.                                                                     
Library charms.traefik_k8s.v0.ingress_per_unit was already up to date in version 0.10.                                                                         

stderr

@Abuelodelanada Abuelodelanada requested a review from sed-i July 5, 2022 17:56
Co-authored-by: Leon <82407168+sed-i@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Jul 5, 2022

Libraries are not up to date with their remote counterparts. If this was
not intentional, run charmcraft fetch-libs and commit the updated libs
to your PR branch.

stdout
Library charms.alertmanager_k8s.v0.alertmanager_dispatch was already up to date in version 0.4.                                                                
Library charms.grafana_k8s.v0.grafana_source was already up to date in version 0.10.                                                                           
Library charms.loki_k8s.v0.loki_push_api has local changes, cannot be updated. 
Library charms.observability_libs.v0.juju_topology was already up to date in version 0.2.                                                                      
Library charms.observability_libs.v0.kubernetes_service_patch was already up to date in version 0.6.                                                           
Library charms.prometheus_k8s.v0.prometheus_scrape was already up to date in version 0.20.                                                                     
Library charms.traefik_k8s.v0.ingress_per_unit was already up to date in version 0.10.                                                                         

stderr

@Abuelodelanada Abuelodelanada requested a review from sed-i July 5, 2022 18:48
@Abuelodelanada Abuelodelanada merged commit ce7cc64 into main Jul 5, 2022
@Abuelodelanada Abuelodelanada deleted the alert_rules branch July 5, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants