Build against 20.04 and a compatible version of glibc #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbarry82
requested review from
sed-i,
Abuelodelanada,
PietroPasotti,
dstathis,
simskij and
lucabello
as code owners
|
This passes now. I'm still not entirely convinced that we need it as a workflow anymore, though. |
lucabello
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Also, bump golang to
1.19.ubuntu-latestis now 22.04, and is not ABI compatible with the tester images being used, so an appropriate version ofglibccan't be found by the linker.We could actually step around this and statically link
glibcin also, but it would require modifying theMakefileforgrafana/lokias part of an action, because it doesn't look for any meaningful env vars we could substitute.With a
grafana-agentmachine snap/charm, do we actually have a need for an in-container rebuilt promtail which can read journalctl?For that matter, is there a reason we're rebuilding this at all instead of grabbing the prebuilt binary from upstream? @simskij ?