Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update source_url when server_cert_changed event is emitted #289

Merged
merged 2 commits into from
Jul 25, 2023
Merged

update source_url when server_cert_changed event is emitted #289

merged 2 commits into from
Jul 25, 2023

Conversation

Abuelodelanada
Copy link
Contributor

PR

This PR updates source_url for GrafanaSourceProvider when cert_changed event is emitted

@Abuelodelanada Abuelodelanada marked this pull request as draft July 24, 2023 15:13
@Abuelodelanada Abuelodelanada marked this pull request as ready for review July 25, 2023 03:31
@Abuelodelanada Abuelodelanada merged commit be24f08 into main Jul 25, 2023
12 checks passed
@Abuelodelanada Abuelodelanada deleted the loki_grafana_tls branch July 25, 2023 03:31
This was referenced Jul 25, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sed-i sed-i sed-i approved these changes

@PietroPasotti PietroPasotti Awaiting requested review from PietroPasotti PietroPasotti is a code owner

@dstathis dstathis Awaiting requested review from dstathis dstathis is a code owner

@simskij simskij Awaiting requested review from simskij simskij is a code owner

@lucabello lucabello Awaiting requested review from lucabello lucabello is a code owner

Assignees
No one assigned
Labels
Libraries: OK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Abuelodelanada @sed-i