daemon.start: stop disabling Apparmor restrictions on unpriv userns/unconfined #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nconfined Those restrictions are not enabled in 23.10 so LXD no longer need to force disable them. If they are enabled, it means the user opted into it, probably for testing the features, in which case LXD shouldn't undo the user's decision. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
|
@tomponline do you also want a separated PR for |
|
yes please |
|
@alexmurray are you happy for us to merge this and LXD will still work on Mantic? |
|
Yes this is backwards compatible with the current snapd / kernel behaviour in mantic. |
|
Oops sorry I thought this was a different PR. Give me a sec to check it m |
|
Yes this is fine to merge, there is no plan to enable the restriction on mantic currently. |
|
@simondeziel please port to latest-candidate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those restrictions are not enabled in 23.10 so LXD no longer need to force disable them. If they are enabled, it means the user opted into it, probably for testing the features, in which case LXD shouldn't undo the user's decision.