snapcraft: add python-uefivars #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no posted a PR for LXD yet, but I'll do that in next few days. It's safe to merge this before that as here we are just adding a new component. |
mihalicyn
force-pushed
the
uefi_vars_edit
branch
from
bdac8ed
to
caf8356
Compare
MusicDin
reviewed
Feb 12, 2024
simondeziel
reviewed
Feb 12, 2024
There was a problem hiding this comment.
Agreed on the version pinning suggested by Din.
As for this new part, it should be noted that once on core24, we will be able to use the python3-uefivars package instead :)
tomponline
reviewed
Feb 13, 2024
Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
We need it for "lxc config uefi <...>" extension There is some trickiness around this thing, because for some reason snapcraft is going crazy and everything that builds after "uefivars" starts to fail with some Python errors (failed to find package XYZ). I have workarounded it by adding "after" specifier for uefivars part. Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
mihalicyn
force-pushed
the
uefi_vars_edit
branch
from
caf8356
to
529449b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need it for "lxc config uefi <...>" extension
There is some trickiness around this thing, because for some reason snapcraft is going crazy and everything that builds after "uefivars" starts to fail with some Python errors (failed to find package XYZ).
I have workarounded it by adding "after" specifier for uefivars part.