Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapcraft: have dqlite build raft #343

Merged
merged 3 commits into from Feb 21, 2024

Conversation

simondeziel
Copy link
Member

The dqlite folks have announced their support for building with --enable-build-raft allowing us to stop caring about raft directly.

@simondeziel
Copy link
Member Author

This passed the lxd-ci cluster locally.

1 similar comment
@simondeziel
Copy link
Member Author

This passed the lxd-ci cluster locally.

@simondeziel simondeziel marked this pull request as ready for review February 20, 2024 20:33
snapcraft.yaml Outdated Show resolved Hide resolved
canonical/dqlite#568

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomponline
Copy link
Member

We cant move this over to latest-candidate until @cole-miller makes a dqlite release with this change.

@tomponline tomponline merged commit 3bee302 into canonical:latest-edge Feb 21, 2024
5 checks passed
@tomponline
Copy link
Member

@simondeziel please can you also update the make deps command and potentially this part of the workflows https://github.com/canonical/lxd/blob/main/.github/workflows/tests.yml#L25-L27 thanks

@simondeziel simondeziel deleted the dqlite-bundling-raft branch February 21, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants