fix(instance) simplify loading state and avoid races on start/stoppin…

…g of instances

Signed-off-by: David Edler <david.edler@canonical.com>

src/context/instanceLoading.tsx

@@ -1,10 +1,4 @@
-import React, {
-  createContext,
-  FC,
-  ReactNode,
-  useContext,
-  useState,
-} from "react";
+import React, { createContext, FC, ReactNode, useContext } from "react";
 import { LxdInstance } from "types/instance";
 
 type LoadingTypes = "Starting" | "Stopping" | "Restarting" | "Freezing";
@@ -26,20 +20,14 @@ interface Props {
 }
 
 export const InstanceLoadingProvider: FC<Props> = ({ children }) => {
-  const [instanceStates, setInstanceStates] = useState(
-    new Map<string, LoadingTypes>(),
-  );
+  const instanceStates = new Map<string, LoadingTypes>();
 
   const setLoading = (instance: LxdInstance, loadingType: LoadingTypes) => {
-    const newMap = new Map(instanceStates);
-    newMap.set(instance.name, loadingType);
-    setInstanceStates(newMap);
+    instanceStates.set(instance.name, loadingType);
   };
 
   const setFinish = (instance: LxdInstance) => {
-    const newMap = new Map(instanceStates);
-    newMap.delete(instance.name);
-    setInstanceStates(newMap);
+    instanceStates.delete(instance.name);
   };
 
   return (