add storage volume detail page

[edlerd]

Done

• add storage volume detail page
• add storage volume configuration page, allows editing of volume configuration
• allow renaming header to have multiple parents

QA

1. Run the LXD-UI:
   • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
   • With a local copy of this branch, run as described here.
2. Perform the following QA steps:
   • check storage volume detail overview
   • check storage volume detail configuration
   • check pages with a rename header

[webteam-app]

Demo starting at https://lxd-ui-472.demos.haus

[piperdeck]

1

Not sure if this is a result of a change in this particular branch, but it seems like the way that the UI reports that a volume is being used might be broken/misbehaving.

The volume "pool-dir/smol-vol" reports that it is being used by 1 instance:

But when you navigate to that instance, it doesn't report being connected to smol-vol at all:

The volume's name and configurations can't be changed while it's being "used", but I can't figure out how to make it stop being used.

There seem to be two possibilities of what's going on:

1. The way in which the UI or core determines that something is attached to it is bugged, and that needs attention.
2. The UI can't communicate certain kinds of connections that block volume customization

2

Unless there's a very specific reason why it's named this way, I would name this configuration tab "Filesystem" rather than "Block", since both of these options are specifically filesystem related.

3

This option here could probably benefit from a little bit of support text, and a link to documentation on mount options such as the Ubuntu manpages. Even for experienced users, it could be nice to have a quick reference here.

[edlerd]

Hey @piperdeck , thanks for the review!

I addressed 2. and 3.

Regarding 1.

There seem to be two possibilities of what's going on:

1. The way in which the UI or core determines that something is attached to it is bugged, and that needs attention.
2. The UI can't communicate certain kinds of connections that block volume customization

This PR does not include the UI for attaching volumes to instances yet. You can see the relation in the YAML view already. So the instance is referencing the volume, just the instance>configuration>storage section can't display it yet. That feature is in this PR and still pending because there are a bunch of issues on it.

[piperdeck]

Changes look good to me!

[piperdeck]

It still says I requested changes. I'm not sure how to make my request go away without breaking anything....

[aaryanporwal]

Looks good to me :)

[aaryanporwal]

@piperdeck if you approve the changes, the request would go away.
Check this doc link on how to do that: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/approving-a-pull-request-with-required-reviews