Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use base style for all cancel buttons #502

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Use base style for all cancel buttons #502

merged 1 commit into from
Oct 23, 2023

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Oct 23, 2023

Done

  • changed appearance of all cancel buttons to base style

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • check cancel buttons in creation/edit forms
    • base appearance for confirmation modals are pending this PR

@webteam-app
Copy link

Demo starting at https://lxd-ui-502.demos.haus

lorumic
lorumic approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@lorumic lorumic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@edlerd edlerd merged commit 9c1d067 into canonical:main Oct 23, 2023
5 checks passed
@edlerd edlerd deleted the cancel-base-appearance branch October 23, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorumic lorumic lorumic approved these changes

@aaryanporwal aaryanporwal Awaiting requested review from aaryanporwal

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edlerd @webteam-app @lorumic