Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tab-links): Refactor into new TabLinks component [WD-6842] #514

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

aaryanporwal
Copy link
Member

@aaryanporwal aaryanporwal commented Oct 27, 2023

Done

  • Refactored all tab usages into a new TabLinks component to reduce code duplication across components.
  • Made tabs links, that can be opened into a new tab etc.

Fixes [list issues/bugs if needed]

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Go to storage page, instance, network, profile, storagepool, storagevolume detail pages and check if the tabs work well.
    • Check that the tabs can be right clicked and opened into a new tab etc. (because the tabs now have a href)

Screenshots

Screen Recording showing tab links

@webteam-app
Copy link

Demo starting at https://lxd-ui-514.demos.haus

@aaryanporwal aaryanporwal changed the title feat(tab-links): Refactor into new TabLinks component feat(tab-links): Refactor into new TabLinks component [WD-6842] Oct 27, 2023
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent, thanks :)
Some ideas to simplify below.

src/components/TabLinks.tsx Outdated Show resolved Hide resolved
src/components/TabLinks.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, thank you for the changes 👍

@edlerd edlerd merged commit d4f1e5c into canonical:main Oct 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants