Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce font size of the text in the cluster group selector #516

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Reduce font size of the text in the cluster group selector #516

merged 1 commit into from
Nov 15, 2023

Conversation

lorumic
Copy link
Contributor

@lorumic lorumic commented Oct 30, 2023 •
edited
Loading

Done

  • Reduced font size of the text in the cluster group selector

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • On a local clustered back-end running this branch: open cluster page and check the group selector at the top of the page.
    • Not really possible to QA on the demo server since its back-end is not clustered. Check the screenshots below.

Screenshots

Before:

image

After:

image

@webteam-app
Copy link

Demo starting at https://lxd-ui-516.demos.haus

edlerd
edlerd approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edlerd edlerd merged commit e92275e into canonical:main Nov 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd edlerd approved these changes

@aaryanporwal aaryanporwal aaryanporwal approved these changes

Assignees

@piperdeck piperdeck

Labels
Review: Code +1 Review: Design +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lorumic @webteam-app @edlerd @aaryanporwal @piperdeck