Ensure correct type is set when creating an instance from a cached image

[lorumic]

Done

• Passed the correct image type when creating an instance from a cached image

QA

1. Run the LXD-UI:
   • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
   • With a local copy of this branch, run as described here.
2. Perform the following QA steps:
   • Go to storage page, select "Cached images" tab
   • Click on the "Play" button to create an instance using a VM cached image (if you don't have one, first create a VM instance following the regular instance creation flow from the instances page)
   • Check that, on the instance creation page, the correct image type is selected in the (disabled) dropdown

[webteam-app]

Demo starting at https://lxd-ui-518.demos.haus

[edlerd]

This breaks the image selector in some cases it sets instance type to "any":

1. Create instance
2. Browse images
3. Select Type VM
4. Select Type Any
5. Choose the 1st image in the list
6. Create
7. Error appears: "Instance creation failed / Invalid instance type"

[edlerd]

Did you forget to push the update @lorumic ? The problem described above is unchanged.

[lorumic]

Did you forget to push the update @lorumic ? The problem described above is unchanged.

No, I didn't find any solution yet. I had a hard time reproducing it and was asking for further clarifications, but then I could reproduce it and deleted my message. I cannot undo the re-request of review though.

[lorumic]

This breaks the image selector in some cases it sets instance type to "any":

Should be fixed now.

[edlerd]

LGTM, thanks for the fixes, two minor suggestions below to improve code.