Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace pause with freeze throughout the app [WD-6701] #519

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Replace pause with freeze throughout the app [WD-6701] #519

merged 1 commit into from
Nov 13, 2023

Conversation

lorumic
Copy link
Contributor

@lorumic lorumic commented Nov 1, 2023 •
edited by jira bot
Loading

Done

  • Replace all occurrences of Pause/Pausing/Paused with Freeze/Freezing/Frozen, to match the back-end status label (Frozen) and avoid confusion.

Fixes WD-6701

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Go to instance page
    • Multi-select instances and check the bulk action labels: "pause" should now be "freeze"
    • Go to instance detail page
    • Check the action labels: "pause" should now be "freeze"

@webteam-app
Copy link

Demo starting at https://lxd-ui-519.demos.haus

edlerd
edlerd approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for taking the initiative on this one!

@lorumic lorumic merged commit 2b89c2b into canonical:main Nov 13, 2023
5 checks passed
@lorumic lorumic deleted the replace-pause-freeze branch November 13, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd edlerd approved these changes

@aaryanporwal aaryanporwal Awaiting requested review from aaryanporwal

Assignees
No one assigned
Labels
Review: Code needed Review: QA needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lorumic @webteam-app @edlerd