Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when leaving the terminal and interacted with it #521

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

lorumic
Copy link
Contributor

@lorumic lorumic commented Nov 2, 2023

Done

  • Migrated the old BrowserRouter to the more modern createBrowserRouter - recommended practice, see docs here.
  • Added a confirmation prompt that is displayed when navigating away from the terminal tab if the user has interacted with the terminal.

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Check that navigation, contexts and routes all work as expected after the migration
    • Go to instance list
    • Open the detail page of a running instance
    • Go to Terminal tab / Console tab
    • Interact with the terminal or the text console, e.g. by writing a command (or just a single letter)
    • Try navigating away, e.g. by clicking on the "Logs" tab
    • Check that a prompt appears asking you if you really want to leave the page
    • Check that the Cancel/OK buttons work as expected

@webteam-app
Copy link

Demo starting at https://lxd-ui-521.demos.haus

Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lorumic lorumic merged commit 1d2ae82 into canonical:main Nov 7, 2023
10 checks passed
@lorumic lorumic deleted the warn-interacted-terminal branch November 7, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants