Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move image list to top level #522

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Nov 7, 2023

Done

  • Move image list to top level
  • rename cached image to images

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • browse the image list form the top main menu
    • delete cached image
    • start new instance and ensure the image appears in cached images
    • check image list for another profile

@webteam-app
Copy link

Demo starting at https://lxd-ui-522.demos.haus

@piperdeck
Copy link

recalling a previous conversation, I approve of this change. I would like to do more work on the images page later on, but if this PR only concerns moving the page itself to the top-level navigation, then it looks good to me.

src/pages/images/ImageList.tsx Outdated Show resolved Hide resolved
src/pages/images/Images.tsx Outdated Show resolved Hide resolved
src/sass/_storage.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@lorumic lorumic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the changes!

@edlerd edlerd merged commit 0bd1d17 into canonical:main Nov 15, 2023
5 checks passed
@edlerd edlerd deleted the move-image-to-top-nav branch November 15, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants