Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to local docs #533

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Link to local docs #533

merged 1 commit into from
Nov 15, 2023

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Nov 14, 2023

Done

  • docs are now shipped with lxd, link to the local docs, when server version is bigger than 5.18

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • check documentation links for a lxd backend with a recent version (bigger than 5.18) -- spot checking should be enough and code review that they are unchanged apart from the base url.

@webteam-app
Copy link

Demo starting at https://lxd-ui-533.demos.haus

Copy link
Contributor

@lorumic lorumic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍

@edlerd edlerd merged commit a3083a3 into canonical:main Nov 15, 2023
5 checks passed
@edlerd edlerd deleted the local-docs branch November 15, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants