-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve storage #535
Merged
Merged
Improve storage #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo starting at https://lxd-ui-535.demos.haus |
edlerd
force-pushed
the
improve-storage
branch
from
November 15, 2023 12:41
0819119
to
2421c4e
Compare
lorumic
requested changes
Nov 17, 2023
edlerd
force-pushed
the
improve-storage
branch
from
November 18, 2023 11:33
2421c4e
to
e819ece
Compare
lorumic
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, just one minor suggestion.
lorumic
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA -1
labels
Nov 20, 2023
edlerd
force-pushed
the
improve-storage
branch
from
November 20, 2023 13:46
e819ece
to
f077c74
Compare
…volume size and content type, better help text for disabled storage volume delete button
edlerd
force-pushed
the
improve-storage
branch
from
November 20, 2023 13:49
f077c74
to
5138f10
Compare
Change the way storage volume content-type and volume-type are displayed throughout the app: With capitalized first letter, and say VM instead of virtual-machine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA