Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve storage #535

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Improve storage #535

merged 1 commit into from
Nov 21, 2023

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Nov 14, 2023

Done

  • address various issues around storage creation/editing discovered during in person review. Notes are in this doc
  • improve link from storage pool detail page to volumes, make it part of the tabs
  • change storage volume filter state, to be persisted in the url, so it can be bookmarked, shared and linked to
  • make content type immutable on storage volume edit form
  • make size immutable on storage volume edit form, when the volume is not of type custom
  • improve help text for disabled storage volume delete button, to hint the user how to remove this storage volume.

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • test storage pool detail page: link to volumes from tab list
    • test filters on storage volume list in url, reload, linking to it and changing filters should work as expected
    • edit a storage volume, ensure size and content type are immutable as described above in the "done" section
    • check the storage volume delete buttons help text from the storage volume list.

@edlerd edlerd requested a review from lorumic November 14, 2023 13:23
@webteam-app
Copy link

Demo starting at https://lxd-ui-535.demos.haus

Copy link
Contributor

@lorumic lorumic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, just one minor suggestion.

…volume size and content type, better help text for disabled storage volume delete button
@edlerd
Copy link
Collaborator Author

edlerd commented Nov 20, 2023

Change the way storage volume content-type and volume-type are displayed throughout the app: With capitalized first letter, and say VM instead of virtual-machine.

@edlerd edlerd merged commit 601a48e into canonical:main Nov 21, 2023
5 checks passed
@edlerd edlerd deleted the improve-storage branch November 21, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants