Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show interface name next to ip addresses WD-7270 #541

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Nov 16, 2023

Done

  • display interface name next to ip address in instance detail page and side panel

Fixes WD-7270

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • check ip addresses are displayed correctly in:
    • instance detail page (with interface)
    • instance list (no interface)
    • instance side panel (with interface)

@webteam-app
Copy link

Demo starting at https://lxd-ui-541.demos.haus

src/pages/instances/InstanceIps.tsx Outdated Show resolved Hide resolved
src/pages/instances/InstanceIps.tsx Outdated Show resolved Hide resolved
…nstance detail page and side panel WD-7270

Update src/pages/networks/forms/NetworkFormBridge.tsx
Update src/pages/instances/InstanceIps.tsx

Co-authored-by: Michele Lo Russo <michele.lorusso@canonical.com>
@edlerd edlerd merged commit 4973751 into canonical:main Nov 21, 2023
5 checks passed
@edlerd edlerd deleted the ip-with-interface branch November 21, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants