Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyboard mappings in graphic console #553

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Nov 23, 2023

Done

  • fix English and foreign language keyboard usage in graphic console. The event scancodes differ by browser, rely instead on the event code, which is stable for most common keys and also more complete.

Fixes #348

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Test the graphic console on a desktop vm. Can be a new VM with ubuntu desktop > detail page > console. Open a terminal in it and start typing. The AltGr and all other keys should work as expected.

…differ by browser, rely instead on the event.code, which is stable for most common keys and more complete canonical#348
@webteam-app
Copy link

Demo starting at https://lxd-ui-553.demos.haus

Copy link
Contributor

@lorumic lorumic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All's well that ends well! :)

@lorumic lorumic merged commit ce12d80 into canonical:main Nov 23, 2023
5 checks passed
@edlerd edlerd deleted the console-keyboard-fixes branch December 1, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Foreign language keyboards not working fully in console
3 participants