Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide cached images when selecting an image for instance creation #554

Merged

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Nov 23, 2023

Done

  • Hide locally cached images when selecting an image for instance launch

Fixes #551

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • create instance > chose image > the list should not list local images if they are cached. Only imported local images should be displayed. Importing is not yet supported by the UI, but possible on the CLI. We should support launching an instance with a local image that was imported in this way.

@webteam-app
Copy link

Demo starting at https://lxd-ui-554.demos.haus

@lorumic lorumic merged commit 17beeab into canonical:main Nov 23, 2023
5 checks passed
@edlerd edlerd deleted the hide-cached-images-in-instance-launch branch December 1, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base image list includes cached images from remotes
3 participants