Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require signed commits #556

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Require signed commits #556

merged 1 commit into from
Nov 23, 2023

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Nov 23, 2023 •
edited
Loading

Done

  • require signing of commits
  • require the CLA for incoming commits

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • ensure pr checks signed commits and the cla and the check passes

@webteam-app
Copy link

Demo starting at https://lxd-ui-556.demos.haus

@edlerd edlerd force-pushed the only-signed-commits-with-cla branch from a4dc409 to 24a58e1 Compare November 23, 2023 16:22
@edlerd
chore(commits) signed commits are mandatory and a cla
f9bbfa2 
Signed-off-by: David Edler <david.edler@canonical.com>
@edlerd edlerd force-pushed the only-signed-commits-with-cla branch from 24a58e1 to f9bbfa2 Compare November 23, 2023 16:22
@lorumic lorumic merged commit 7adc5f4 into canonical:main Nov 23, 2023
6 checks passed
@edlerd edlerd deleted the only-signed-commits-with-cla branch December 1, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorumic lorumic lorumic approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edlerd @webteam-app @lorumic