Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests) created tests for instance and profile panels WD-7370 #561

Merged
merged 1 commit into from
Nov 28, 2023
Merged

chore(tests) created tests for instance and profile panels WD-7370 #561

merged 1 commit into from
Nov 28, 2023

Conversation

mas-who
Copy link
Contributor

@mas-who mas-who commented Nov 28, 2023

Done

  • Added tests for instance and profile side panels

@mas-who
chore(tests) created tests for instance and profile panels WD-7370
ec75d8c 
Signed-off-by: Mason Hu <mason.hu@canonical.com>
@mas-who mas-who requested a review from edlerd November 28, 2023 16:26
@webteam-app
Copy link

Demo starting at https://lxd-ui-561.demos.haus

edlerd
edlerd approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, well done :)
Let's wait for the test suite to finish -- when it passes here, we can merge it.

@mas-who mas-who merged commit ccf07a8 into main Nov 28, 2023
6 checks passed
@edlerd edlerd deleted the side-panel-tests branch December 1, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd edlerd approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mas-who @webteam-app @edlerd