feat(storage) add warning for project snapshot restriction [WD-7885]

[mas-who]

Done

• If the project has snapshot restrictions, then a warning is shown for instance and custom storage volume snapshot settings page.
• Removed a duplicated component StorageVolueSnapshotsForm.tsx. There is a pre-existing component StorageVolumeFormSnapshots.tsx which serves the exact same purpose.

QA

1. Run the LXD-UI:
   • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
   • With a local copy of this branch, run as described here.
2. Perform the following QA steps:
   • Navigate to the side panel Configuration tab, set Allow custom restrictions on a project level to true.
   • Navigate to a instance's detail page, under the Configuration tab, click on the Snapshots menu item and you should see a warning indicating that snapshot creation is blocked for the current project.
   • Navigate to the Snapshots tab within the same instance detail page, click on the See configuration button. You should see the same warning in the pop up modal.
   • Navigate to a custom storage volume's detail page, under the Configuration tab, click on the Snapshots menu item and you should see a warning indicating that snapshot creation is blocked for the current project.
   • Navigate to the Snapshots tab within the same custom storage volume detail page, click on the See configuration button. You should see the same warning in the pop up modal.

[webteam-app]

Demo starting at https://lxd-ui-577.demos.haus

[edlerd]

Code and QA looks good to me, maybe find a better or shorter copy as suggested below.

[edlerd]

All good, thanks for adjusting the notification copy

[mas-who]

All good, thanks for adjusting the notification copy

Should we still wait for piper to do a design review on this?

[piperdeck]

I think this copy might be a little clearer:

(Snapshots tab)
Snapshot creation has been disabled for instances in the the project {project name}.

(Warning message)
Snapshot creation has been disabled for instances in the project {project name}.
If you have administrator privileges, you can change this setting [here].

In the last message, would it be possible to include a link to the configuration page where the setting can be changed back?

[mas-who]

I think this copy might be a little clearer:

(Snapshots tab) Snapshot creation has been disabled for instances in the the project {project name}.

(Warning message) Snapshot creation has been disabled for instances in the project {project name}. If you have administrator privileges, you can change this setting [here].

In the last message, would it be possible to include a link to the configuration page where the setting can be changed back?

@piperdeck the snapshots tab warning message makes sense. I think we can take it one step further for the configuration warning message. We can maybe display a different message for restricted users since they will not be allowed to edit project configurations. See below screenshots, WDYT? Also, this would be done for both instance and custom storage volume snapshot configurations.

For non-restricted users

For restricted users

[edlerd]

Ideas to simplify and reduce code below.

[edlerd]

Thanks for the changes, tiny nitpick about copy. Links should always be descriptive of the target document, it is discouraged to use "here" as a link text.

[edlerd]

All good, thanks for applying the changes 👍