Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on actual project list for selection of default project #582

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Dec 13, 2023

Done

  • Rely on actual project list for selection of default project
  • fix invalid object access for restricted users

Fixes #575

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • try access to the UI with a restricted user (lxc config trust list then lxc config trust edit $id then change restricted: true and add a project which is or is not the default project)
    • The restricted user should be redirected to a project they have access to (i.e. non-default) when opening the /ui url in a browser.

@webteam-app
Copy link

Demo starting at https://lxd-ui-582.demos.haus

src/context/auth.tsx Outdated Show resolved Hide resolved
@mas-who
Copy link
Contributor

mas-who commented Dec 14, 2023

QA'd locally with the changes since I can't ssh into the demo server node yet. LGTM with just one small nit comment.

…ect, fix invalid object access for restricted users canonical#575

Signed-off-by: David Edler <david.edler@canonical.com>
@mas-who mas-who merged commit 02ad008 into canonical:main Dec 14, 2023
7 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 14, 2023
@edlerd edlerd deleted the fix-restricted-users branch January 9, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI fails to login when the user isn't allowed access to the default project
3 participants