fix: switch back to pull_request event trigger for gh actions #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://lxd-ui-591.demos.haus |
Signed-off-by: Mason Hu <mason.hu@canonical.com>
mas-who
force-pushed
the
remove-publish-report-job
branch
from
8a447ed
to
7b574b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
pull_requestevent trigger instead ofpull_request_targetfor the pr check action. Thepull_request_targetevent trigger was put in place so that we can get write permissions with theGITHUB_TOKENfor foreign (forked) PRs as actions would be run in the context of the base repository. However, it seems actions are actually running in context of the main branch as well which will disregard incoming changes.