Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pulish playwright reports using github action (v2) #592

Merged
merged 1 commit into from
Jan 4, 2024
Merged

chore: pulish playwright reports using github action (v2) #592

merged 1 commit into from
Jan 4, 2024

Conversation

mas-who
Copy link
Contributor

@mas-who mas-who commented Jan 3, 2024

Done

  • Publish playwright reports using github actions using workflow_run event trigger

@webteam-app
Copy link

Demo starting at https://lxd-ui-592.demos.haus

@mas-who mas-who force-pushed the publish-playwright-report-v2 branch 5 times, most recently from 05edce2 to 830d0a8 Compare January 3, 2024 15:56
@mas-who mas-who force-pushed the publish-playwright-report-v2 branch from 830d0a8 to 9a7c650 Compare January 3, 2024 17:17
edlerd
edlerd approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We could simplify further -- maybe no need to parse the pr number, run id and run attempt for the commit message. The commit message could be the same each time, or just contain the full path as it is. But also fine to keep as it is from my side.

@mas-who
Copy link
Contributor Author

mas-who commented Jan 4, 2024

LGTM

We could simplify further -- maybe no need to parse the pr number, run id and run attempt for the commit message. The commit message could be the same each time, or just contain the full path as it is. But also fine to keep as it is from my side.

Oh my bad, I misunderstood you yesterday, thought you wanted to not store the additional information in the info.txt but still display them. Will just display the path in the commit message then.

@mas-who mas-who force-pushed the publish-playwright-report-v2 branch from 9a7c650 to 68f445e Compare January 4, 2024 07:13
edlerd
edlerd approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes. Two minor typos below, then ready for merge 👍

.github/workflows/publish_test_reports.yml Outdated
timeout-minutes: 3
run: |
git add .
git commit -m "workflow: add HTML report publised at $HTML_REPORT_URL_PATH"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
git commit -m "workflow: add HTML report publised at $HTML_REPORT_URL_PATH"
git commit -m "workflow: add HTML report published at $HTML_REPORT_URL_PATH"

.github/workflows/delete_test_reports.yml Outdated Show resolved Hide resolved
@mas-who
chore: pulish playwright reports using github action (v2)
d024324 
Signed-off-by: Mason Hu <mason.hu@canonical.com>
@mas-who mas-who force-pushed the publish-playwright-report-v2 branch from 68f445e to d024324 Compare January 4, 2024 10:11
@mas-who mas-who merged commit 81997b6 into main Jan 4, 2024
6 checks passed
@edlerd edlerd deleted the publish-playwright-report-v2 branch February 21, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd edlerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mas-who @webteam-app @edlerd