Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use supported storage driver options from server settings [WD-8144] #600

Merged
merged 1 commit into from
Jan 15, 2024
Merged

feat: use supported storage driver options from server settings [WD-8144] #600

merged 1 commit into from
Jan 15, 2024

Conversation

mas-who
Copy link
Contributor

@mas-who mas-who commented Jan 15, 2024

Done

  • Generate storage driver options based on server settings

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Create a storage pool and check that the storage driver options selector is populated correctly

@webteam-app
Copy link

Demo starting at https://lxd-ui-600.demos.haus

edlerd
edlerd approved these changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some ideas to simplify below.

src/util/storageOptions.tsx Outdated Show resolved Hide resolved
src/util/storageOptions.tsx Outdated Show resolved Hide resolved
src/util/storageOptions.tsx Outdated Show resolved Hide resolved
@mas-who
feat: use supported storage driver options from server settings
88f830a 
Signed-off-by: Mason Hu <mason.hu@canonical.com>
@mas-who
Copy link
Contributor Author

mas-who commented Jan 15, 2024

LGTM, some ideas to simplify below.

Thanks for the review, I have implemented your suggestions 🙂

@edlerd
Copy link
Collaborator

edlerd commented Jan 15, 2024

Thanks for the review, I have implemented your suggestions 🙂

Thanks, had another look and all seems good to merge now -- assuming the CI passes.

@mas-who mas-who merged commit 64ff69e into canonical:main Jan 15, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 15, 2024
workflow: remove all reports for PR #600
12a3854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd edlerd approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mas-who @webteam-app @edlerd