Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies #613

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Remove unused dependencies #613

merged 1 commit into from
Jan 23, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Jan 19, 2024

Done

  • Remove unused dependencies

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • ensure ci passes
    • spot check demo server

@webteam-app
Copy link

Demo starting at https://lxd-ui-613.demos.haus

Signed-off-by: David Edler <david.edler@canonical.com>
@mas-who
Copy link
Contributor

mas-who commented Jan 23, 2024

LGTM. Let's first merge #621 then let CI run one more time before we merge this PR

@edlerd
Copy link
Collaborator Author

edlerd commented Jan 23, 2024

LGTM. Let's first merge #621 then let CI run one more time before we merge this PR

I'll merge this first, as #621 has conflicts anyhow that need to be resolved. Will rebase and check CI on #621

@edlerd edlerd merged commit 28aa0f5 into canonical:main Jan 23, 2024
6 checks passed
@edlerd edlerd deleted the cleanup-deps branch January 23, 2024 09:03
github-actions bot pushed a commit that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants