Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve several a11y issues #619

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Improve several a11y issues #619

merged 1 commit into from
Jan 23, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Jan 22, 2024

Done

  • Improve several a11y issues
  • Ensure playwright report and link gets published on test failures

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • ensure below form elements are improved:
    • edit instance, profile selector label
    • edit profile, add custom disk device, volume selector label
    • edit profile, edit custom disk device, rename device name label
    • edit profile, root storage size unit label
    • edit profile, memory unit selector label
    • instance detail page, logs, heading structure is correct (h1 then h2)
    • Instance list page, heading structure
    • edit network, ipv4 address custom radio button label
    • settings, all boolean inputs have a readable label, and help text is properly spaced
    • storage volume list, heading structure

@webteam-app
Copy link

Demo starting at https://lxd-ui-619.demos.haus

Signed-off-by: David Edler <david.edler@canonical.com>
@@ -134,6 +134,7 @@ jobs:
run: npx playwright test

- name: Save additional test information
if: always()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this!

@mas-who
Copy link
Contributor

mas-who commented Jan 23, 2024

LGTM.

@edlerd edlerd merged commit 224632b into canonical:main Jan 23, 2024
6 checks passed
@edlerd edlerd deleted the fix-a11y branch January 23, 2024 09:09
github-actions bot pushed a commit that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants