Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add p-breadcrumbs--large class to avoid upstream conflicts #624

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

aaryanporwal
Copy link
Member

Done

  • Added a new breadcrumbs-large class to the breadcrumbs to avoid polluting vanilla classes.

Fixes [list issues/bugs if needed]

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Check all the breadcrumbs in detail pages look as they should be.

Screenshots

[if relevant, include a screenshot or screen capture]

@webteam-app
Copy link

Demo starting at https://lxd-ui-624.demos.haus

Signed-off-by: Aaryan Porwal <aaryan.porwal@canonical.com>
@mas-who
Copy link
Contributor

mas-who commented Jan 25, 2024

LGTM.

@edlerd edlerd merged commit 1d57f75 into canonical:main Jan 25, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants