Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace admonition markup in help texts #628

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Jan 31, 2024

Done

  • add rules to replace admonition markup
  • remove cleanup of {{snapshot_pattern_detail}}, was fixed upstream.

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Check project configuration > restrictions > device usage > disk devices > activate override and validate help text below the input
    • Check storage volume configuration > snapshots > pattern > activate override and validate help text below the input

@webteam-app
Copy link

Demo starting at https://lxd-ui-628.demos.haus

Signed-off-by: David Edler <david.edler@canonical.com>
@edlerd edlerd force-pushed the config-api-replace-admonition-markup branch from 01a13f8 to c035e6b Compare January 31, 2024 15:14
@mas-who
Copy link
Contributor

mas-who commented Jan 31, 2024

code looks good, just waiting for demo to go up for QA.

@mas-who
Copy link
Contributor

mas-who commented Jan 31, 2024

LGTM. 👍

@mas-who mas-who merged commit e38803b into canonical:main Jan 31, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 31, 2024
@edlerd edlerd deleted the config-api-replace-admonition-markup branch January 31, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants