Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix styling for actions list after v0.49.0 update for react-components #633

Merged
merged 1 commit into from
Feb 5, 2024
Merged

fix: fix styling for actions list after v0.49.0 update for react-components #633

merged 1 commit into from
Feb 5, 2024

Conversation

mas-who
Copy link
Contributor

@mas-who mas-who commented Feb 5, 2024

Done

  • Fixed styling for actions list

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Check that the actions list no longer have weird spacing issues.

@mas-who
fix: fix styling for actions list after v0.49.0 update for react-comp…
c9d711b 
…onents

Signed-off-by: Mason Hu <mason.hu@canonical.com>
@webteam-app
Copy link

Demo starting at https://lxd-ui-633.demos.haus

@edlerd edlerd merged commit 762dd44 into canonical:main Feb 5, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 5, 2024
workflow: remove all reports for PR #633
cfb83c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorumic lorumic lorumic approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mas-who @webteam-app @lorumic @edlerd