Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve playwright report artifact upload conflict #643

Merged
merged 2 commits into from
Feb 13, 2024
Merged

fix: resolve playwright report artifact upload conflict #643

merged 2 commits into from
Feb 13, 2024

Conversation

mas-who
Copy link
Contributor

@mas-who mas-who commented Feb 13, 2024

Done

  • Removed workflow step that uploads the merged playwright reports for the second time

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Ensure CI passes and that the playwright report is visible at the URL produced by the merge-e2e-report job

@webteam-app
Copy link

Demo starting at https://lxd-ui-643.demos.haus

edlerd
edlerd approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing.

Edit: QA is good, one comment on code below.

edlerd
edlerd requested changes Feb 13, 2024
View reviewed changes
playwright.config.ts Outdated Show resolved Hide resolved
@mas-who
fix: resolve playwright report artifact upload conflict
9f32d54 
Signed-off-by: Mason Hu <mason.hu@canonical.com>
edlerd
edlerd approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thanks for fixing it quickly!

@mas-who
chore: remove expect timeout constant and adjusted global expect time…
068eda1 
…out constant for playwright

Signed-off-by: Mason Hu <mason.hu@canonical.com>
@mas-who mas-who requested a review from edlerd February 13, 2024 11:44
@edlerd edlerd merged commit a60565c into canonical:main Feb 13, 2024
8 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 13, 2024
workflow: remove all reports for PR #643
c4980c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd Awaiting requested review from edlerd

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mas-who @webteam-app @edlerd