Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scrolling for network forwards #644

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Feb 13, 2024

Done

  • make network forwards page scroll only table content

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • check network forwards page with many forwards

@webteam-app
Copy link

Demo starting at https://lxd-ui-644.demos.haus

@mas-who
Copy link
Contributor

mas-who commented Feb 13, 2024

The scrolling behaviour is fine, but I a styling issue when I was playing around with the screen width. There seems to be borders around the table body and header rows when the screen width is reduced, was this the intended design?

Screenshot from 2024-02-13 15-31-09

@edlerd
Copy link
Collaborator Author

edlerd commented Feb 13, 2024

The scrolling behaviour is fine, but I a styling issue when I was playing around with the screen width. There seems to be borders around the table body and header rows when the screen width is reduced, was this the intended design?

Good catch, removed the switching to card view. This should improve behaviour on small widths.

@mas-who
Copy link
Contributor

mas-who commented Feb 13, 2024

LGTM 👍

Signed-off-by: David Edler <david.edler@canonical.com>
@edlerd edlerd merged commit ce2bc04 into canonical:main Feb 13, 2024
8 checks passed
@edlerd edlerd deleted the scroll-forwards branch February 13, 2024 15:28
github-actions bot pushed a commit that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants