Make rows in iso and custom-volume modals clickable

[edlerd]

Done

• Make rows in iso and custom-volume modals clickable

Fixes WD-8689

QA

1. Run the LXD-UI:
   • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
   • With a local copy of this branch, run as described here.
2. Perform the following QA steps:
   • check "choose custom iso" modal on instance creation. Each iso row should have a hover effect, a pointer cursor and be clickable, same experience as the "select image" modal on instance creation
   • check the instance configuration > disk devices > attach custom device modal, row selection should be same as above iso/image selection

[webteam-app]

Demo starting at https://lxd-ui-673.demos.haus

[mas-who]

QA looks good! I did however pick up that the custom volume modal have some weird vertical scroll behaviour, I think maybe we should adjust the table height so that the action buttons are always in view? Feel free to skip this one though since it's not in the scope of this PR.

[edlerd]

QA looks good! I did however pick up that the custom volume modal have some weird vertical scroll behaviour, I think maybe we should adjust the table height so that the action buttons are always in view? Feel free to skip this one though since it's not in the scope of this PR.

Yes, this was a display bug due to pagination -- which I think shouldn't have been enabled within the modals in the first place. I removed the pagination, and now it should be fixed.

[mas-who]

QA looks good! I did however pick up that the custom volume modal have some weird vertical scroll behaviour, I think maybe we should adjust the table height so that the action buttons are always in view? Feel free to skip this one though since it's not in the scope of this PR.

Yes, this was a display bug due to pagination -- which I think shouldn't have been enabled within the modals in the first place. I removed the pagination, and now it should be fixed.

Great, thanks for the change, it looks good now! 👍

[piperdeck]

I like this. The only thing I notice that feels a bit wonky is something that probably doesn't have to do with this PR in particular, but it seems like the breakpoints for switching between the full and compact versions of this table are a little over-tuned. It switches to the compact version when the modal still has lots of room to remain full-sized:

Screen.Recording.2024-02-27.at.2.19.56.PM.mov

Other than that, it looks good to me

[edlerd]

I like this. The only thing I notice that feels a bit wonky is something that probably doesn't have to do with this PR in particular, but it seems like the breakpoints for switching between the full and compact versions of this table are a little over-tuned. It switches to the compact version when the modal still has lots of room to remain full-sized:

This was due to the table configured as responsive, which is not really necessary. I removed that, and it should be fixed now.

[piperdeck]

Awesome, this is looking good.