Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set security.nesting param #675

Closed
wants to merge 1 commit into from
Closed

Conversation

monkz
Copy link

@monkz monkz commented Feb 26, 2024

-- Signed Off: Malte Wagner git@monkz.de

Done

  • Insert forgotten security option

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • [List the steps to QA the new feature(s) or prove that a bug has been resolved]

Screenshots

[if relevant, include a screenshot or screen capture]

@webteam-app
Copy link

monkz is not a collaborator of the repo

@edlerd
Copy link
Collaborator

edlerd commented Feb 26, 2024

Hi @monkz thank you for the PR!

Can you please sign off your commits?

The test failures look unrelated to your changes. We had a fix for unstable test land in main earlier today. Can you rebase on latest main branch to pull in the fixes to your branch?

Signed-off-by: Malte Wagner <git@monkz.de>
@edlerd
Copy link
Collaborator

edlerd commented Feb 27, 2024

Thanks again for the adjustments!

@monkz has not signed the Canonical CLA which is required to get this contribution merged on this project.
Please head over to https://ubuntu.com/legal/contributors to read more about it.

@monkz
Copy link
Author

monkz commented Feb 27, 2024

Hi @edlerd . Sorry but that won't happen. My contribution is licensed GPLv3.

@edlerd
Copy link
Collaborator

edlerd commented Feb 27, 2024

Sorry we can't accept PRs without CLA

@edlerd edlerd closed this Apr 16, 2024
github-actions bot pushed a commit that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants