Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix used by links to snapshots of custom storage volumes #683

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Fix used by links to snapshots of custom storage volumes #683

merged 1 commit into from
Feb 28, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Feb 27, 2024 •
edited
Loading

Done

  • Fix used by links to snapshots of custom storage volumes

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Open storage pool detail page, the used by section previously wrongly treated custom storage pool snapshots as instance snapshots, resulting in invalid links. This works now as expected. Previous error here. Fixed used by section here

@webteam-app
Copy link

Demo starting at https://lxd-ui-683.demos.haus

@edlerd
fix(storage) correct used by links to snapshots of custom storage values
5e2aa30 
Signed-off-by: David Edler <david.edler@canonical.com>
@edlerd edlerd force-pushed the fix-used-by-storage branch 2 times, most recently from 56fbb12 to 5e2aa30 Compare February 27, 2024 19:02
@edlerd edlerd changed the title Fix used by links to snapshots of custom storage values Fix used by links to snapshots of custom storage volumes Feb 27, 2024
@mas-who
Copy link
Contributor

mas-who commented Feb 28, 2024

LGTM, thanks for fixing this!

@edlerd edlerd merged commit 9881d18 into canonical:main Feb 28, 2024
10 checks passed
@edlerd edlerd deleted the fix-used-by-storage branch February 28, 2024 07:47
github-actions bot pushed a commit that referenced this pull request Feb 28, 2024
workflow: remove all reports for PR #683
e0a7479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mas-who mas-who mas-who approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edlerd @webteam-app @mas-who