fix: prevent custom config keys being removed when updating resources [WD-9348] #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://lxd-ui-691.demos.haus |
mas-who
changed the title
mas-who
commented
Mar 8, 2024
mas-who
force-pushed
the
persist-custom-keys
branch
from
cb7da4a
to
c2de01d
Compare
edlerd
reviewed
Mar 11, 2024
edlerd
requested changes
Mar 11, 2024
mas-who
force-pushed
the
persist-custom-keys
branch
2 times, most recently
from
7c781f7
to
f0e5ec4
Compare
edlerd
approved these changes
Mar 11, 2024
edlerd
reviewed
Mar 11, 2024
- Checked edit instances (using getUnhandledKeyValues) - Checked edit profile (using getUnhandledKeyValues) - Checked edit network (using yaml object) - Checked edit network forward (no config keys) - Checked edit storage pool (using PATCH request so it's not a problem) - Checked edit storage volume (updated to use getUnhandledKeyValues) - Checked edit snapshot (no config keys) - Checked edit image (can't edit images so not a problem) - Checked edit project (using getUnhandledKeyValues) Signed-off-by: Mason Hu <mason.hu@canonical.com>
mas-who
force-pushed
the
persist-custom-keys
branch
from
f0e5ec4
to
cbc4c1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
getUnhandledKeyValues)getUnhandledKeyValues)getUnhandledKeyValues)getUnhandledKeyValues)QA
lxc [resource-type] set [resource-name] user.foo=bar, then check its configs usinglxc [resource-type] show [resource-name]and confirmuser.foois present in the resource configs. From there, navigate to the edit page for that resource type, modify anything and then hit save. Runlxc [resource-type] show [resource-name]again and confirm thatuser.foois still present in the configs. NOTE: thelxccommand for setting and showing resource configs can be slightly different depending on the resource type, please check the MAN page relating to each resource type's cli commands.