Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use config api for network form help texts and defaults #695

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Mar 13, 2024

Done

  • Use config api for network form help texts and defaults
  • unify network form key handling

Fixes WD-7391

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • check create/edit managed networks and ensure the help texts are displayed correctly

@webteam-app
Copy link

Demo starting at https://lxd-ui-695.demos.haus

@edlerd edlerd force-pushed the config-api-network branch 2 times, most recently from 307baff to 0910de2 Compare March 13, 2024 12:04
…, unify network form key handling WD-7391

Signed-off-by: David Edler <david.edler@canonical.com>
@mas-who
Copy link
Contributor

mas-who commented Mar 14, 2024

LGTM, also tested user custom keys when editing networks and it did not regress 👍

@edlerd edlerd merged commit c2cc226 into canonical:main Mar 14, 2024
10 checks passed
@edlerd edlerd deleted the config-api-network branch March 14, 2024 09:09
github-actions bot pushed a commit that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants