Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create instance from custom iso #696

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

mas-who
Copy link
Contributor

@mas-who mas-who commented Mar 13, 2024

Done

  • Fixed issue when creating an instance from the custom ISO list, the redirect may result in invalid instance type locked for the instance creation page.

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • upload foo.iso (from test fixtures), go to Storage -> Custom ISOs and try create an instance from the uploaded custom iso. No error should show (i.e. invalid instance type) when the instance gets created.

Signed-off-by: Mason Hu <mason.hu@canonical.com>
@webteam-app
Copy link

Demo starting at https://lxd-ui-696.demos.haus

Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for fixing it :)

@mas-who mas-who merged commit fbac3d3 into canonical:main Mar 13, 2024
10 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants