Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor side panels and enabled overlay panels #698

Merged
merged 1 commit into from
Mar 14, 2024
Merged

feat: refactor side panels and enabled overlay panels #698

merged 1 commit into from
Mar 14, 2024

Conversation

mas-who
Copy link
Contributor

@mas-who mas-who commented Mar 13, 2024

Done

  • Removed the DetailPanel and Aside components and refactored them into a compound component SidePanel
  • Introduced overlay styling variable for the side panel
  • Updated InstanceDetailPanel and ProfileDetailPanel to use SidePanel

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Ensure that instance detail panel and profile detail panel still works as expected.

@webteam-app
Copy link

Demo starting at https://lxd-ui-698.demos.haus

@mas-who mas-who requested a review from edlerd March 13, 2024 17:42
edlerd
edlerd reviewed Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The composable SidePanel is super nice. Some ideas on structure and naming things below.

src/components/SidePanel.tsx Show resolved Hide resolved
src/components/SidePanel.tsx Outdated Show resolved Hide resolved
src/pages/instances/InstanceDetailPanel.tsx Outdated Show resolved Hide resolved
src/pages/instances/InstanceDetailPanel.tsx Outdated Show resolved Hide resolved
src/pages/profiles/ProfileDetailPanel.tsx Outdated Show resolved Hide resolved
src/sass/_overlay_panel.scss Outdated Show resolved Hide resolved
src/sass/_overlay_panel.scss Outdated Show resolved Hide resolved
@mas-who mas-who requested a review from edlerd March 14, 2024 12:46
@mas-who mas-who force-pushed the refactor-side-panels branch 2 times, most recently from 2e9ce86 to b812857 Compare March 14, 2024 13:32
@mas-who
feat: refactor side panels and enabled overlay panels
6cef4fd 
Signed-off-by: Mason Hu <mason.hu@canonical.com>
edlerd
edlerd approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's perfect, thanks :)

@mas-who mas-who merged commit 8240ade into canonical:main Mar 14, 2024
10 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 14, 2024
workflow: remove all reports for PR #698
9ef11d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd edlerd approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mas-who @webteam-app @edlerd