Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward scroll event from vm to parent container #702

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Mar 18, 2024

Done

  • Forward scroll event from vm to parent container
  • Fix height on vm resize to avoid scrollbars

Fixes #700

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Test a VM with graphic console. Scrolling when hovering the VM should also scroll the parent html container.

…anonical#700

Signed-off-by: David Edler <david.edler@canonical.com>
@webteam-app
Copy link

Demo starting at https://lxd-ui-702.demos.haus

@mas-who
Copy link
Contributor

mas-who commented Mar 20, 2024

LGTM 👍

@edlerd edlerd merged commit 5af14ce into canonical:main Mar 20, 2024
10 checks passed
@edlerd edlerd deleted the fix-vm-scroll branch March 20, 2024 11:07
github-actions bot pushed a commit that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants