Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure login button is not broken into two rows #711

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Mar 25, 2024

Done

  • Changed login screen layout, so it won't break the "Create a new certificate" button is not split into more than one row on medium-sized screens

Fixes WD-9657

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • test the login screen on various screen widths.

@webteam-app
Copy link

Demo starting at https://lxd-ui-711.demos.haus

src/sass/_login.scss Outdated Show resolved Hide resolved
@mas-who
Copy link
Contributor

mas-who commented Mar 26, 2024

QA looks good, just one small query regarding the new styles.

…sized screens WD-9657

Signed-off-by: David Edler <david.edler@canonical.com>
@edlerd edlerd merged commit caaa0ae into canonical:main Mar 27, 2024
10 checks passed
@edlerd edlerd deleted the fix-login-btn branch March 27, 2024 09:05
github-actions bot pushed a commit that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants