Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove all monaco-editor directories when uploading coverage report bundle #725

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

mas-who
Copy link
Contributor

@mas-who mas-who commented Apr 5, 2024

Done

  • The coverage report is failing due to files in monaco-editor directory, the path also seems to change. Let's try to remove all monaco-editor directories no matter where they are located and see if this works.

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Ensure CI passes

…rt bundle

Signed-off-by: Mason Hu <mason.hu@canonical.com>
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hope it helps.

@mas-who mas-who merged commit 3783e81 into canonical:main Apr 8, 2024
10 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants