Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react components #774

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented May 22, 2024

Done

  • use new empty state layout more in line with vanilla
  • update react-components

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • test empty state

Screenshots

New instance empty state
image

@webteam-app
Copy link

@mas-who
Copy link
Contributor

mas-who commented May 22, 2024

Thanks for this update. I think the empty state looks fine on normal pages but seems to be a bit far to the right in side panels. Should we collapse the left margin for empty state in side panels?

Screenshot from 2024-05-22 13-48-52

Signed-off-by: David Edler <david.edler@canonical.com>
@edlerd
Copy link
Collaborator Author

edlerd commented May 22, 2024

Thanks for this update. I think the empty state looks fine on normal pages but seems to be a bit far to the right in side panels. Should we collapse the left margin for empty state in side panels?

Good catch, side panels are a special case. I updated them to be full width. Please check again.

@mas-who
Copy link
Contributor

mas-who commented May 22, 2024

Thanks for this update. I think the empty state looks fine on normal pages but seems to be a bit far to the right in side panels. Should we collapse the left margin for empty state in side panels?

Good catch, side panels are a special case. I updated them to be full width. Please check again.

Yeah I think it looks pretty good now 👍

@edlerd edlerd merged commit 52be253 into canonical:main May 24, 2024
12 checks passed
@edlerd edlerd deleted the update-react-components branch May 24, 2024 07:35
github-actions bot pushed a commit that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants