Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI: enforce older version of requests library when installing dotrun #775

Merged
merged 1 commit into from
May 22, 2024
Merged

Fix CI: enforce older version of requests library when installing dotrun #775

merged 1 commit into from
May 22, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented May 22, 2024

Done

  • fix ci, work around a recently introduced bug in requests library

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • ensure ci is passing

@edlerd
fix(ci) enforce older version of requests when installing dotrun to w…
1b54aaf 
…ork around a recently introduced bug in it

Signed-off-by: David Edler <david.edler@canonical.com>
@webteam-app
Copy link

Demo

Jenkins

demos.haus

@edlerd edlerd changed the title Enforce older version of requests when installing dotrun Enforce older version of requests library when installing dotrun May 22, 2024
@edlerd edlerd changed the title Enforce older version of requests library when installing dotrun Fix CI: enforce older version of requests library when installing dotrun May 22, 2024
@mas-who
Copy link
Contributor

mas-who commented May 22, 2024

LGTM, can merge after CI passes. Thanks for fixing this 👍

@edlerd edlerd mentioned this pull request May 22, 2024
Merged
@edlerd edlerd merged commit 487ba59 into canonical:main May 22, 2024
9 of 11 checks passed
@edlerd edlerd deleted the fix-workflows branch May 22, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mas-who mas-who mas-who approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edlerd @webteam-app @mas-who